Vergleich modcp.php - 1.8.29 - 1.8.39

Zeile 2064	Zeile 2064
{ $attachments = array_map("intval", array_keys($mybb->input['attachments'])); $query = $db->query("	{ $attachments = array_map("intval", array_keys($mybb->input['attachments'])); $query = $db->query("
SELECT a.pid, a.aid	SELECT a.pid, a.aid, t.tid
FROM ".TABLE_PREFIX."attachments a LEFT JOIN ".TABLE_PREFIX."posts p ON (a.pid=p.pid) LEFT JOIN ".TABLE_PREFIX."threads t ON (t.tid=p.tid)	FROM ".TABLE_PREFIX."attachments a LEFT JOIN ".TABLE_PREFIX."posts p ON (a.pid=p.pid) LEFT JOIN ".TABLE_PREFIX."threads t ON (t.tid=p.tid)
Zeile 2080	Zeile 2080
if($action == "approve") { $db->update_query("attachments", array("visible" => 1), "aid='{$attachment['aid']}'");	if($action == "approve") { $db->update_query("attachments", array("visible" => 1), "aid='{$attachment['aid']}'");
	if(isset($attachment['tid'])) { update_thread_counters((int)$attachment['tid'], array("attachmentcount" => "+1")); }
} else if($action == "delete") { remove_attachment($attachment['pid'], '', $attachment['aid']);	} else if($action == "delete") { remove_attachment($attachment['pid'], '', $attachment['aid']);
	if(isset($attachment['tid'])) { update_thread_counters((int)$attachment['tid'], array("attachmentcount" => "-1")); }
} } $plugins->run_hooks("modcp_do_modqueue_end");	} } $plugins->run_hooks("modcp_do_modqueue_end");

redirect("modcp.php?action=modqueue&type=attachments", $lang->redirect_attachmentsmoderated); } }	redirect("modcp.php?action=modqueue&type=attachments", $lang->redirect_attachmentsmoderated); } }
Zeile 2100	Zeile 2108
if($mybb->usergroup['canmanagemodqueue'] == 0) { error_no_permission();	if($mybb->usergroup['canmanagemodqueue'] == 0) { error_no_permission();
}	}
if($nummodqueuethreads == 0 && $nummodqueueposts == 0 && $nummodqueueattach == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_use_mod_queue);	if($nummodqueuethreads == 0 && $nummodqueueposts == 0 && $nummodqueueattach == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_use_mod_queue);
Zeile 2114	Zeile 2122
if($nummodqueuethreads == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_moderate_threads);	if($nummodqueuethreads == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_moderate_threads);
}	}
$forum_cache = $cache->read("forums");	$forum_cache = $cache->read("forums");

$query = $db->simple_select("threads", "COUNT(tid) AS unapprovedthreads", "visible='0' {$flist_queue_threads}"); $unapproved_threads = $db->fetch_field($query, "unapprovedthreads"); // Figure out if we need to display multiple pages. if($mybb->get_input('page') != "last")	$query = $db->simple_select("threads", "COUNT(tid) AS unapprovedthreads", "visible='0' {$flist_queue_threads}"); $unapproved_threads = $db->fetch_field($query, "unapprovedthreads"); // Figure out if we need to display multiple pages. if($mybb->get_input('page') != "last")
{	{
$page = $mybb->get_input('page', MyBB::INPUT_INT);	$page = $mybb->get_input('page', MyBB::INPUT_INT);
}	}
$perpage = $mybb->settings['threadsperpage']; $pages = $unapproved_threads / $perpage;	$perpage = $mybb->settings['threadsperpage']; $pages = $unapproved_threads / $perpage;
$pages = ceil($pages); if($mybb->get_input('page') == "last") { $page = $pages; } if($page > $pages \|\| $page <= 0) { $page = 1; } if($page) { $start = ($page-1) * $perpage; } else { $start = 0; $page = 1; }	$pages = ceil($pages); if($mybb->get_input('page') == "last") { $page = $pages; } if($page > $pages \|\| $page <= 0) { $page = 1; } if($page) { $start = ($page-1) * $perpage; } else { $start = 0; $page = 1; }
$multipage = multipage($unapproved_threads, $perpage, $page, "modcp.php?action=modqueue&type=threads");	$multipage = multipage($unapproved_threads, $perpage, $page, "modcp.php?action=modqueue&type=threads");
Zeile 2178	Zeile 2186
{ $thread['threadusername'] = htmlspecialchars_uni($thread['threadusername']); $profile_link = $thread['threadusername'];	{ $thread['threadusername'] = htmlspecialchars_uni($thread['threadusername']); $profile_link = $thread['threadusername'];
} else { $profile_link = $lang->guest; } }	} else { $profile_link = $lang->guest; } }
else	else
{	{
$thread['username'] = htmlspecialchars_uni($thread['username']); $profile_link = build_profile_link($thread['username'], $thread['uid']);	$thread['username'] = htmlspecialchars_uni($thread['username']); $profile_link = build_profile_link($thread['username'], $thread['uid']);
}	}
$thread['postmessage'] = nl2br(htmlspecialchars_uni($thread['postmessage'])); eval("\$forum = \"".$templates->get("modcp_modqueue_link_forum")."\";"); eval("\$threads .= \"".$templates->get("modcp_modqueue_threads_thread")."\";");	$thread['postmessage'] = nl2br(htmlspecialchars_uni($thread['postmessage'])); eval("\$forum = \"".$templates->get("modcp_modqueue_link_forum")."\";"); eval("\$threads .= \"".$templates->get("modcp_modqueue_threads_thread")."\";");
}	}
if(!$threads && $mybb->input['type'] == "threads") {	if(!$threads && $mybb->input['type'] == "threads") {
Zeile 2205	Zeile 2213
add_breadcrumb($lang->mcp_nav_modqueue_threads, "modcp.php?action=modqueue&type=threads"); $plugins->run_hooks("modcp_modqueue_threads_end");	add_breadcrumb($lang->mcp_nav_modqueue_threads, "modcp.php?action=modqueue&type=threads"); $plugins->run_hooks("modcp_modqueue_threads_end");

if($nummodqueueposts > 0 \|\| $mybb->usergroup['issupermod'] == 1) { $navsep = " \| ";	if($nummodqueueposts > 0 \|\| $mybb->usergroup['issupermod'] == 1) { $navsep = " \| ";
eval("\$post_link = \"".$templates->get("modcp_modqueue_post_link")."\";"); } if($mybb->settings['enableattachments'] == 1 && ($nummodqueueattach > 0 \|\| $mybb->usergroup['issupermod'] == 1)) { $navsep = " \| "; eval("\$attachment_link = \"".$templates->get("modcp_modqueue_attachment_link")."\";"); } eval("\$mass_controls = \"".$templates->get("modcp_modqueue_masscontrols")."\";");	eval("\$post_link = \"".$templates->get("modcp_modqueue_post_link")."\";"); } if($mybb->settings['enableattachments'] == 1 && ($nummodqueueattach > 0 \|\| $mybb->usergroup['issupermod'] == 1)) { $navsep = " \| "; eval("\$attachment_link = \"".$templates->get("modcp_modqueue_attachment_link")."\";"); } eval("\$mass_controls = \"".$templates->get("modcp_modqueue_masscontrols")."\";");
eval("\$threadqueue = \"".$templates->get("modcp_modqueue_threads")."\";"); output_page($threadqueue); }	eval("\$threadqueue = \"".$templates->get("modcp_modqueue_threads")."\";"); output_page($threadqueue); }
Zeile 2230	Zeile 2238
if($nummodqueueposts == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_moderate_posts);	if($nummodqueueposts == 0 && $mybb->usergroup['issupermod'] != 1) { error($lang->you_cannot_moderate_posts);
} $forum_cache = $cache->read("forums");	} $forum_cache = $cache->read("forums");
$query = $db->query(" SELECT COUNT(pid) AS unapprovedposts	$query = $db->query(" SELECT COUNT(pid) AS unapprovedposts
Zeile 2253	Zeile 2261
$pages = ceil($pages); if($mybb->get_input('page') == "last")	$pages = ceil($pages); if($mybb->get_input('page') == "last")
{	{
$page = $pages; }	$page = $pages; }
Zeile 2322	Zeile 2330
if(!$posts && $mybb->input['type'] == "posts") { eval("\$posts = \"".$templates->get("modcp_modqueue_posts_empty")."\";");	if(!$posts && $mybb->input['type'] == "posts") { eval("\$posts = \"".$templates->get("modcp_modqueue_posts_empty")."\";");
}	}
if($posts) { add_breadcrumb($lang->mcp_nav_modqueue_posts, "modcp.php?action=modqueue&type=posts");	if($posts) { add_breadcrumb($lang->mcp_nav_modqueue_posts, "modcp.php?action=modqueue&type=posts");

$plugins->run_hooks("modcp_modqueue_posts_end"); if($nummodqueuethreads > 0 \|\| $mybb->usergroup['issupermod'] == 1)	$plugins->run_hooks("modcp_modqueue_posts_end"); if($nummodqueuethreads > 0 \|\| $mybb->usergroup['issupermod'] == 1)
{	{
$navsep = " \| "; eval("\$thread_link = \"".$templates->get("modcp_modqueue_thread_link")."\";");	$navsep = " \| "; eval("\$thread_link = \"".$templates->get("modcp_modqueue_thread_link")."\";");
}	}
if($mybb->settings['enableattachments'] == 1 && ($nummodqueueattach > 0 \|\| $mybb->usergroup['issupermod'] == 1)) { $navsep = " \| ";	if($mybb->settings['enableattachments'] == 1 && ($nummodqueueattach > 0 \|\| $mybb->usergroup['issupermod'] == 1)) { $navsep = " \| ";
Zeile 2356	Zeile 2364
} if($nummodqueueattach == 0 && $mybb->usergroup['issupermod'] != 1)	} if($nummodqueueattach == 0 && $mybb->usergroup['issupermod'] != 1)
{	{
error($lang->you_cannot_moderate_attachments); }	error($lang->you_cannot_moderate_attachments); }
Zeile 2561	Zeile 2569
"profile_fields" => $mybb->get_input('profile_fields', MyBB::INPUT_ARRAY), "profile_fields_editable" => true, "website" => $mybb->get_input('website'),	"profile_fields" => $mybb->get_input('profile_fields', MyBB::INPUT_ARRAY), "profile_fields_editable" => true, "website" => $mybb->get_input('website'),
"icq" => $mybb->get_input('icq'),
"skype" => $mybb->get_input('skype'), "google" => $mybb->get_input('google'), "signature" => $mybb->get_input('signature'),	"skype" => $mybb->get_input('skype'), "google" => $mybb->get_input('google'), "signature" => $mybb->get_input('signature'),
Zeile 2768	Zeile 2775
if(!my_validate_url($user['website'])) { $user['website'] = '';	if(!my_validate_url($user['website'])) { $user['website'] = '';
} if($user['icq'] != "0") { $user['icq'] = (int)$user['icq'];
} if(!$errors)	} if(!$errors)
Zeile 2784	Zeile 2786
$birthday[1] = ''; } if(!isset($birthday[2]))	$birthday[1] = ''; } if(!isset($birthday[2]))
{	{
$birthday[2] = ''; } list($mybb->input['birthday_day'], $mybb->input['birthday_month'], $mybb->input['birthday_year']) = $birthday;	$birthday[2] = ''; } list($mybb->input['birthday_day'], $mybb->input['birthday_month'], $mybb->input['birthday_year']) = $birthday;
}	}
else { $errors = inline_error($errors);	else { $errors = inline_error($errors);
}	}
// Sanitize all input	// Sanitize all input
foreach(array('usertitle', 'website', 'icq', 'skype', 'google', 'signature', 'birthday_day', 'birthday_month', 'birthday_year') as $field)	foreach(array('usertitle', 'website', 'skype', 'google', 'signature', 'birthday_day', 'birthday_month', 'birthday_year') as $field)
{ $mybb->input[$field] = htmlspecialchars_uni($mybb->get_input($field)); }	{ $mybb->input[$field] = htmlspecialchars_uni($mybb->get_input($field)); }
Zeile 2817	Zeile 2819
$defaulttitle = htmlspecialchars_uni($title['title']); break; }	$defaulttitle = htmlspecialchars_uni($title['title']); break; }
} } $user['usertitle'] = htmlspecialchars_uni($user['usertitle']);	} } $user['usertitle'] = htmlspecialchars_uni($user['usertitle']);
if(empty($user['usertitle'])) { $lang->current_custom_usertitle = '';	if(empty($user['usertitle'])) { $lang->current_custom_usertitle = '';
Zeile 2848	Zeile 2850
$bdaymonthsel[$month] = ''; } $bdaymonthsel[$mybb->input['birthday_month']] = 'selected="selected"';	$bdaymonthsel[$month] = ''; } $bdaymonthsel[$mybb->input['birthday_month']] = 'selected="selected"';
	$awaysection = '';
if($mybb->settings['allowaway'] != 0) {	if($mybb->settings['allowaway'] != 0) {
Zeile 3191	Zeile 3195
${$option['time']} = $mybb->get_input($option['time'], MyBB::INPUT_INT); // Display the suspension info, if this user has this option suspended if($user[$option['option']])	${$option['time']} = $mybb->get_input($option['time'], MyBB::INPUT_INT); // Display the suspension info, if this user has this option suspended if($user[$option['option']])
{	{
if($user[$option['length']] == 0) { // User has a permanent ban	if($user[$option['length']] == 0) { // User has a permanent ban
Zeile 3259	Zeile 3263
if(!isset($newtitle)) { $newtitle = '';	if(!isset($newtitle)) { $newtitle = '';
}	}
$birthday_year = $mybb->input['birthday_year']; $user_website = $mybb->input['website'];	$birthday_year = $mybb->input['birthday_year']; $user_website = $mybb->input['website'];
$user_icq = $mybb->input['icq'];
$user_skype = $mybb->input['skype']; $user_google = $mybb->input['google'];	$user_skype = $mybb->input['skype']; $user_google = $mybb->input['google'];
Zeile 3364	Zeile 3367
foreach(array('username', 'sortby', 'order') as $field) { if(!empty($mybb->input[$field]))	foreach(array('username', 'sortby', 'order') as $field) { if(!empty($mybb->input[$field]))
{	{
$page_url .= "&{$field}=".$mybb->input[$field]; } }	$page_url .= "&{$field}=".$mybb->input[$field]; } }

$multipage = multipage($user_count, $perpage, $page, $page_url);	$multipage = multipage($user_count, $perpage, $page, $page_url);

$usergroups_cache = $cache->read("usergroups");	$usergroups_cache = $cache->read("usergroups");

$plugins->run_hooks("modcp_finduser_start"); // Fetch out results	$plugins->run_hooks("modcp_finduser_start"); // Fetch out results
Zeile 3388	Zeile 3391
if($user['invisible'] == 1 && $mybb->usergroup['canviewwolinvis'] != 1 && $user['uid'] != $mybb->user['uid']) {	if($user['invisible'] == 1 && $mybb->usergroup['canviewwolinvis'] != 1 && $user['uid'] != $mybb->user['uid']) {
$lastdate = $lang->lastvisit_never; if($user['lastvisit']) { // We have had at least some active time, hide it instead $lastdate = $lang->lastvisit_hidden; }	// We have had at least some active time, hide it instead $lastdate = $lang->lastvisit_hidden; } else if($user['lastvisit']) { $lastdate = my_date('relative', $user['lastvisit']);
} else {	} else {
$lastdate = my_date('relative', $user['lastvisit']);	$lastdate = $lang->lastvisit_never;
} $usergroup = htmlspecialchars_uni($usergroups_cache[$user['usergroup']]['title']);	} $usergroup = htmlspecialchars_uni($usergroups_cache[$user['usergroup']]['title']);
Zeile 3437	Zeile 3439
$mybb->input['filter']['uid'] = (int)$search_user['uid']; $mybb->input['filter']['username'] = htmlspecialchars_uni($mybb->input['filter']['username']);	$mybb->input['filter']['uid'] = (int)$search_user['uid']; $mybb->input['filter']['username'] = htmlspecialchars_uni($mybb->input['filter']['username']);
}	}
else { $mybb->input['filter']['username'] = '';	else { $mybb->input['filter']['username'] = '';
Zeile 3472	Zeile 3474
$search['mod_uid'] = (int)$mybb->input['filter']['mod_uid']; $where_sql .= " AND w.issuedby='{$search['mod_uid']}'"; if(!isset($mybb->input['search']['mod_username']))	$search['mod_uid'] = (int)$mybb->input['filter']['mod_uid']; $where_sql .= " AND w.issuedby='{$search['mod_uid']}'"; if(!isset($mybb->input['search']['mod_username']))
{	{
$mod_user = get_user($mybb->input['search']['uid']); $mybb->input['search']['mod_username'] = htmlspecialchars_uni($mod_user['username']); }	$mod_user = get_user($mybb->input['search']['uid']); $mybb->input['search']['mod_username'] = htmlspecialchars_uni($mod_user['username']); }
Zeile 3672	Zeile 3674
// Searching post IP addresses if(isset($mybb->input['search_posts'])) {	// Searching post IP addresses if(isset($mybb->input['search_posts'])) {
	$post_ip_sql = '';
if($ip_range) { if(!is_array($ip_range))	if($ip_range) { if(!is_array($ip_range))
Zeile 3766	Zeile 3769
// Searching user IP addresses if(isset($mybb->input['search_users'])) {	// Searching user IP addresses if(isset($mybb->input['search_users'])) {
	$user_ip_sql = '';
if($ip_range) { if(!is_array($ip_range))	if($ip_range) { if(!is_array($ip_range))
Zeile 3936	Zeile 3940
foreach($ipaddresses as $ipaddress) { $ip = my_inet_ntop($db->unescape_binary($ipaddress['ipaddress']));	foreach($ipaddresses as $ipaddress) { $ip = my_inet_ntop($db->unescape_binary($ipaddress['ipaddress']));
if(!$ipaddress['username'])	if(empty($ipaddress['username']))
{ $ipaddress['username'] = $ipaddress['postusername']; // Guest username support } $ipaddress['username'] = htmlspecialchars_uni($ipaddress['username']); $trow = alt_trow();	{ $ipaddress['username'] = $ipaddress['postusername']; // Guest username support } $ipaddress['username'] = htmlspecialchars_uni($ipaddress['username']); $trow = alt_trow();
if(!$ipaddress['subject'])	if(empty($ipaddress['subject']))
{ $ipaddress['subject'] = "RE: {$ipaddress['threadsubject']}"; }	{ $ipaddress['subject'] = "RE: {$ipaddress['threadsubject']}"; }
Zeile 4259	Zeile 4263
"); $user = $db->fetch_array($query);	"); $user = $db->fetch_array($query);
if($user['uid'])	if($user)
{ $existing_ban = true; }	{ $existing_ban = true; }
Zeile 4283	Zeile 4287
$user = get_user_by_username($mybb->input['username'], $options);	$user = get_user_by_username($mybb->input['username'], $options);
if(!$user['uid'])	if(!$user)
{ $errors[] = $lang->invalid_username; }	{ $errors[] = $lang->invalid_username; }
Zeile 4308	Zeile 4312
// Check banned group $usergroups_cache = $cache->read('usergroups');	// Check banned group $usergroups_cache = $cache->read('usergroups');
$usergroup = $usergroups_cache[$mybb->get_input('usergroup', MyBB::INPUT_INT)];	if(isset($usergroups_cache[$mybb->get_input('usergroup', MyBB::INPUT_INT)])) { $usergroup = $usergroups_cache[$mybb->get_input('usergroup', MyBB::INPUT_INT)]; }

if(empty($usergroup['gid']) \|\| empty($usergroup['isbannedgroup']))	if(!isset($usergroup) \|\| empty($usergroup['isbannedgroup']))
{ $errors[] = $lang->error_nobangroup; }	{ $errors[] = $lang->error_nobangroup; }