Vergleich showthread.php - 1.8.23 - 1.8.27

  Keine Änderungen   Hinzugefügt   Modifiziert   Entfernt
Zeile 51Zeile 51
		$query = $db->simple_select("posts", "fid,tid,visible", "pid=".$mybb->get_input('pid', MyBB::INPUT_INT), $options);
$post = $db->fetch_array($query);


		$query = $db->simple_select("posts", "fid,tid,visible", "pid=".$mybb->get_input('pid', MyBB::INPUT_INT), $options);
$post = $db->fetch_array($query);


		if(empty($post) || ($post['visible'] == 0 && !is_moderator($post['fid'], 'canviewunapprove')) || ($post['visible'] == -1 && !is_moderator($post['fid'], 'canviewdeleted')))










		if(
empty($post) ||
(
$post['visible'] == 0 && !(
is_moderator($post['fid'], 'canviewunapprove') ||
($mybb->user['uid'] && $post['uid'] == $mybb->user['uid'] && $mybb->settings['showownunapproved'])
)
) ||
($post['visible'] == -1 && !is_moderator($post['fid'], 'canviewdeleted'))
)

		{
// post does not exist --> show corresponding error
error($lang->error_invalidpost);

		{
// post does not exist --> show corresponding error
error($lang->error_invalidpost);

Zeile 103Zeile 112
$forumpermissions = forum_permissions($thread['fid']);

// Set here to fetch only approved/deleted posts (and then below for a moderator we change this).

$forumpermissions = forum_permissions($thread['fid']);

// Set here to fetch only approved/deleted posts (and then below for a moderator we change this).

 
$visible_states = array("1");


if($forumpermissions['canviewdeletionnotice'] != 0)
{

if($forumpermissions['canviewdeletionnotice'] != 0)
{

	$visibleonly = " AND visible IN (-1,1)";
$visibleonly2 = "AND p.visible IN (-1,1) AND t.visible IN (-1,1)";
}
else
{
$visibleonly = " AND visible=1";
$visibleonly2 = "AND p.visible=1 AND t.visible=1";
}

// Is the currently logged in user a moderator of this forum?
if(is_moderator($fid))
{

	$visible_states[] = "-1";
}

// Is the currently logged in user a moderator of this forum?
if(is_moderator($fid))
{







	$ismod = true;

	$ismod = true;

	if(is_moderator($fid, "canviewdeleted") == true || is_moderator($fid, "canviewunapprove") == true)





	if(is_moderator($fid, "canviewdeleted") == true)
{
$visible_states[] = "-1";
}
if(is_moderator($fid, "canviewunapprove") == true)

	{

	{

		if(is_moderator($fid, "canviewunapprove") == true && is_moderator($fid, "canviewdeleted") == false)
{
$visibleonly = " AND visible IN (0,1)";
$visibleonly2 = "AND p.visible IN (0,1) AND t.visible IN (0,1)";
}
elseif(is_moderator($fid, "canviewdeleted") == true && is_moderator($fid, "canviewunapprove") == false)
{
$visibleonly = " AND visible IN (-1,1)";
$visibleonly2 = "AND p.visible IN (-1,1) AND t.visible IN (-1,1)";
}
else
{
$visibleonly = " AND visible IN (-1,0,1)";
$visibleonly2 = "AND p.visible IN (-1,0,1) AND t.visible IN (-1,0,1)";
}

		$visible_states[] = "0";















	}
}
else
{

	}
}
else
{

	$ismod = false;



















	$ismod = false;
}

$visible_condition = "visible IN (".implode(',', array_unique($visible_states)).")";

// Allow viewing own unapproved threads for logged in users
if($mybb->user['uid'] && $mybb->settings['showownunapproved'])
{
$own_unapproved = ' AND (%1$s'.$visible_condition.' OR (%1$svisible=0 AND %1$suid='.(int)$mybb->user['uid'].'))';

$visibleonly = sprintf($own_unapproved, null);
$visibleonly_p = sprintf($own_unapproved, 'p.');
$visibleonly_p_t = sprintf($own_unapproved, 'p.').sprintf($own_unapproved, 't.');
}
else
{
$visibleonly = " AND ".$visible_condition;
$visibleonly_p = " AND p.".$visible_condition;
$visibleonly_p_t = "AND p.".$visible_condition." AND t.".$visible_condition;

}

// Make sure we are looking at a real thread here.

}

// Make sure we are looking at a real thread here.

Zeile 249Zeile 262
	$options = array(
"limit_start" => 0,
"limit" => 1,

	$options = array(
"limit_start" => 0,
"limit" => 1,

		"order_by" => "dateline",
"order_dir" => "asc"

		"order_by" => "dateline, pid",


	);

$lastread = (int)$lastread;

	);

$lastread = (int)$lastread;

Zeile 289Zeile 301
			SELECT p.pid
FROM ".TABLE_PREFIX."posts p
LEFT JOIN ".TABLE_PREFIX."threads t ON(p.tid=t.tid)

			SELECT p.pid
FROM ".TABLE_PREFIX."posts p
LEFT JOIN ".TABLE_PREFIX."threads t ON(p.tid=t.tid)

			WHERE t.fid='".$thread['fid']."' AND t.closed NOT LIKE 'moved|%' {$visibleonly2}
ORDER BY p.dateline DESC

			WHERE t.fid='".$thread['fid']."' AND t.closed NOT LIKE 'moved|%' {$visibleonly_p_t}
ORDER BY p.dateline DESC, p.pid DESC

			LIMIT 1
");
$pid = $db->fetch_field($query, "pid");

			LIMIT 1
");
$pid = $db->fetch_field($query, "pid");

Zeile 298Zeile 310
	else
{
$options = array(

	else
{
$options = array(

			'order_by' => 'dateline',
'order_dir' => 'desc',

			'order_by' => 'dateline DESC, pid DESC',


			'limit_start' => 0,
'limit' => 1
);

			'limit_start' => 0,
'limit' => 1
);

Zeile 329Zeile 340
	$options = array(
"limit_start" => 0,
"limit" => 1,

	$options = array(
"limit_start" => 0,
"limit" => 1,

		"order_by" => "dateline",
"order_dir" => "desc"

		"order_by" => "dateline DESC, pid DESC",


	);
$query = $db->simple_select('posts', 'pid', "tid='{$nextthread['tid']}'", $options);


	);
$query = $db->simple_select('posts', 'pid', "tid='{$nextthread['tid']}'", $options);


Zeile 343Zeile 353
// Jump to the next oldest posts.
if($mybb->input['action'] == "nextoldest")
{

// Jump to the next oldest posts.
if($mybb->input['action'] == "nextoldest")
{

	$options = array(
"limit" => 1,
"limit_start" => 0,

	$options = array(
"limit" => 1,
"limit_start" => 0,

		"order_by" => "lastpost",
"order_dir" => "desc"
);

		"order_by" => "lastpost",
"order_dir" => "desc"
);

Zeile 360Zeile 370
	$options = array(
"limit_start" => 0,
"limit" => 1,

	$options = array(
"limit_start" => 0,
"limit" => 1,

		"order_by" => "dateline",
"order_dir" => "desc"

		"order_by" => "dateline DESC, pid DESC",


	);
$query = $db->simple_select("posts", "pid", "tid='".$nextthread['tid']."'", $options);


	);
$query = $db->simple_select("posts", "pid", "tid='".$nextthread['tid']."'", $options);


Zeile 534Zeile 543
				"filter_badwords" => 1
);


				"filter_badwords" => 1
);


			if($mybb->user['showimages'] != 1 && $mybb->user['uid'] != 0 || $mybb->settings['guestimages'] != 1 && $mybb->user['uid'] == 0)

			if($mybb->user['uid'] != 0 && $mybb->user['showimages'] != 1 || $mybb->settings['guestimages'] != 1 && $mybb->user['uid'] == 0)

			{
$parser_options['allow_imgcode'] = 0;
}


			{
$parser_options['allow_imgcode'] = 0;
}


			if($mybb->user['showvideos'] != 1 && $mybb->user['uid'] != 0 || $mybb->settings['guestvideos'] != 1 && $mybb->user['uid'] == 0)

			if($mybb->user['uid'] != 0 && $mybb->user['showvideos'] != 1 || $mybb->settings['guestvideos'] != 1 && $mybb->user['uid'] == 0)

			{
$parser_options['allow_videocode'] = 0;
}

			{
$parser_options['allow_videocode'] = 0;
}

Zeile 552Zeile 561
			// Mark the option the user voted for.
if(!empty($votedfor[$number]))
{

			// Mark the option the user voted for.
if(!empty($votedfor[$number]))
{

				$optionbg = "trow2";

				$optionbg = "trow2 poll_votedfor";

				$votestar = "*";
}
else

				$votestar = "*";
}
else

Zeile 603Zeile 612
		if(is_moderator($fid, 'canmanagepolls'))
{
eval("\$edit_poll = \"".$templates->get("showthread_poll_editpoll")."\";");

		if(is_moderator($fid, 'canmanagepolls'))
{
eval("\$edit_poll = \"".$templates->get("showthread_poll_editpoll")."\";");

		}


		}


		// Decide what poll status to show depending on the status of the poll and whether or not the user voted already.
if(isset($alreadyvoted) || isset($showresults) || isset($nopermission))
{

		// Decide what poll status to show depending on the status of the poll and whether or not the user voted already.
if(isset($alreadyvoted) || isset($showresults) || isset($nopermission))
{

Zeile 644Zeile 653
			{
$publicnote = $lang->public_note;
}

			{
$publicnote = $lang->public_note;
}





			eval("\$pollbox = \"".$templates->get("showthread_poll")."\";");
$plugins->run_hooks("showthread_poll");
}

			eval("\$pollbox = \"".$templates->get("showthread_poll")."\";");
$plugins->run_hooks("showthread_poll");
}


}


}

	else
{
$pollbox = "";

	else
{
$pollbox = "";

	}


	}


	// Create the forum jump dropdown box.
if($mybb->settings['enableforumjump'] != 0)
{

	// Create the forum jump dropdown box.
if($mybb->settings['enableforumjump'] != 0)
{

Zeile 664Zeile 673
	// Fetch some links
$next_oldest_link = get_thread_link($tid, 0, "nextoldest");
$next_newest_link = get_thread_link($tid, 0, "nextnewest");

	// Fetch some links
$next_oldest_link = get_thread_link($tid, 0, "nextoldest");
$next_newest_link = get_thread_link($tid, 0, "nextnewest");





	// Mark this thread as read
mark_thread_read($tid, $fid);

	// Mark this thread as read
mark_thread_read($tid, $fid);





	// If the forum is not open, show closed newreply button unless the user is a moderator of this forum.
$newthread = $newreply = '';
if($forum['open'] != 0 && $forum['type'] == "f")

	// If the forum is not open, show closed newreply button unless the user is a moderator of this forum.
$newthread = $newreply = '';
if($forum['open'] != 0 && $forum['type'] == "f")

Zeile 678Zeile 687
		}

// Show the appropriate reply button if this thread is open or closed

		}

// Show the appropriate reply button if this thread is open or closed

		if($forumpermissions['canpostreplys'] != 0 && $mybb->user['suspendposting'] != 1 && ($thread['closed'] != 1 || is_moderator($fid, "canpostclosedthreads")) && ($thread['uid'] == $mybb->user['uid'] || $forumpermissions['canonlyreplyownthreads'] != 1))

		if($forumpermissions['canpostreplys'] != 0 && $mybb->user['suspendposting'] != 1 && ($thread['closed'] != 1 || is_moderator($fid, "canpostclosedthreads")) && ($thread['uid'] == $mybb->user['uid'] || empty($forumpermissions['canonlyreplyownthreads'])))

		{
eval("\$newreply = \"".$templates->get("showthread_newreply")."\";");
}
elseif($thread['closed'] == 1)
{
eval("\$newreply = \"".$templates->get("showthread_newreply_closed")."\";");

		{
eval("\$newreply = \"".$templates->get("showthread_newreply")."\";");
}
elseif($thread['closed'] == 1)
{
eval("\$newreply = \"".$templates->get("showthread_newreply_closed")."\";");

		}

		}

	}

// Create the admin tools dropdown box.
if($ismod == true)
{

	}

// Create the admin tools dropdown box.
if($ismod == true)
{

		$closelinkch = $stickch = '';

		$closeoption = $closelinkch = $stickch = '';


if($thread['closed'] == 1)


if($thread['closed'] == 1)

		{

		{

			$closelinkch = ' checked="checked"';

			$closelinkch = ' checked="checked"';

		}

		}


if($thread['sticky'])


if($thread['sticky'])

		{

		{

			$stickch = ' checked="checked"';
}

if(is_moderator($thread['fid'], "canopenclosethreads"))
{
eval("\$closeoption .= \"".$templates->get("showthread_quickreply_options_close")."\";");

			$stickch = ' checked="checked"';
}

if(is_moderator($thread['fid'], "canopenclosethreads"))
{
eval("\$closeoption .= \"".$templates->get("showthread_quickreply_options_close")."\";");

		}

		}


if(is_moderator($thread['fid'], "canstickunstickthreads"))


if(is_moderator($thread['fid'], "canstickunstickthreads"))

		{

		{

			eval("\$closeoption .= \"".$templates->get("showthread_quickreply_options_stick")."\";");

			eval("\$closeoption .= \"".$templates->get("showthread_quickreply_options_stick")."\";");

		}

		}


$inlinecount = "0";
$inlinecookie = "inlinemod_thread".$tid;


$inlinecount = "0";
$inlinecookie = "inlinemod_thread".$tid;

Zeile 725Zeile 734
	}

// Increment the thread view.

	}

// Increment the thread view.

	if($mybb->settings['delayedthreadviews'] == 1)













	if(
(
$mybb->user['uid'] == 0 &&
(
($session->is_spider == true && $mybb->settings['threadviews_countspiders'] == 1) ||
($session->is_spider == false && $mybb->settings['threadviews_countguests'] == 1)
)
) ||
(
$mybb->user['uid'] != 0 &&
($mybb->settings['threadviews_countthreadauthor'] == 1 || $mybb->user['uid'] != $thread['uid'])
)
)

	{

	{

		$db->shutdown_query("INSERT INTO ".TABLE_PREFIX."threadviews (tid) VALUES('{$tid}')");









		if($mybb->settings['delayedthreadviews'] == 1)
{
$db->shutdown_query("INSERT INTO ".TABLE_PREFIX."threadviews (tid) VALUES('{$tid}')");
}
else
{
$db->shutdown_query("UPDATE ".TABLE_PREFIX."threads SET views=views+1 WHERE tid='{$tid}'");
}
++$thread['views'];

	}

	}

	else
{
$db->shutdown_query("UPDATE ".TABLE_PREFIX."threads SET views=views+1 WHERE tid='{$tid}'");
}
++$thread['views'];

 

// Work out the thread rating for this thread.


// Work out the thread rating for this thread.

	$rating = '';

	$rating = $ratethread = '';

	if($mybb->settings['allowthreadratings'] != 0 && $forum['allowtratings'] != 0)
{
$rated = 0;

	if($mybb->settings['allowthreadratings'] != 0 && $forum['allowtratings'] != 0)
{
$rated = 0;

Zeile 770Zeile 794

$ratingvotesav = $lang->sprintf($lang->rating_average, $thread['numratings'], $thread['averagerating']);
eval("\$ratethread = \"".$templates->get("showthread_ratethread")."\";");


$ratingvotesav = $lang->sprintf($lang->rating_average, $thread['numratings'], $thread['averagerating']);
eval("\$ratethread = \"".$templates->get("showthread_ratethread")."\";");

	}
// Work out if we are showing unapproved posts as well (if the user is a moderator etc.)
if($ismod && is_moderator($fid, "canviewdeleted") == true && is_moderator($fid, "canviewunapprove") == false)
{
$visible = "AND p.visible IN (-1,1)";
}
elseif($ismod && is_moderator($fid, "canviewdeleted") == false && is_moderator($fid, "canviewunapprove") == true)
{
$visible = "AND p.visible IN (0,1)";
}
elseif($ismod && is_moderator($fid, "canviewdeleted") == true && is_moderator($fid, "canviewunapprove") == true)
{
$visible = "AND p.visible IN (-1,0,1)";
}
elseif($forumpermissions['canviewdeletionnotice'] != 0 && $ismod == false)
{
$visible = "AND p.visible IN (-1,1)";
}
else
{
$visible = "AND p.visible='1'";

 
	}

// Can this user perform searches? If so, we can show them the "Search thread" form
if($forumpermissions['cansearch'] != 0)

	}

// Can this user perform searches? If so, we can show them the "Search thread" form
if($forumpermissions['cansearch'] != 0)

	{

	{

		eval("\$search_thread = \"".$templates->get("showthread_search")."\";");
}


		eval("\$search_thread = \"".$templates->get("showthread_search")."\";");
}


Zeile 807Zeile 810
		foreach($ignore_list as $uid)
{
$ignored_users[$uid] = 1;

		foreach($ignore_list as $uid)
{
$ignored_users[$uid] = 1;

		}
}

// Fetch profile fields to display on postbit
$pfcache = $cache->read('profilefields');

if(is_array($pfcache))
{
foreach($pfcache as $profilefield)
{
if($profilefield['postbit'] != 1)
{
continue;
}

$profile_fields[$profilefield['fid']] = $profilefield;
}
}


		}
}


















	// Which thread mode is our user using by default?
if(!empty($mybb->user['threadmode']))
{

	// Which thread mode is our user using by default?
if(!empty($mybb->user['threadmode']))
{

Zeile 850Zeile 837
	$threadexbox = '';
if($mybb->get_input('mode') == 'threaded')
{

	$threadexbox = '';
if($mybb->get_input('mode') == 'threaded')
{

 
		$thread_toggle = 'linear';

		$isfirst = 1;

// Are we linked to a specific pid?

		$isfirst = 1;

// Are we linked to a specific pid?

Zeile 859Zeile 847
		}
else
{

		}
else
{

			$where = " ORDER BY dateline LIMIT 0, 1";

			$where = " ORDER BY dateline, pid LIMIT 0, 1";

		}
$query = $db->query("
SELECT u.*, u.username AS userusername, p.*, f.*, r.reporters, eu.username AS editusername

		}
$query = $db->query("
SELECT u.*, u.username AS userusername, p.*, f.*, r.reporters, eu.username AS editusername

Zeile 868Zeile 856
			LEFT JOIN ".TABLE_PREFIX."users u ON (u.uid=p.uid)
LEFT JOIN ".TABLE_PREFIX."userfields f ON (f.ufid=u.uid)
LEFT JOIN ".TABLE_PREFIX."users eu ON (eu.uid=p.edituid)

			LEFT JOIN ".TABLE_PREFIX."users u ON (u.uid=p.uid)
LEFT JOIN ".TABLE_PREFIX."userfields f ON (f.ufid=u.uid)
LEFT JOIN ".TABLE_PREFIX."users eu ON (eu.uid=p.edituid)

			WHERE p.tid='$tid' $visible $where

			WHERE p.tid='$tid' $visibleonly_p $where

		");
$showpost = $db->fetch_array($query);


		");
$showpost = $db->fetch_array($query);


Zeile 882Zeile 870
		if(!$showpost['pid'])
{
error($lang->error_invalidpost);

		if(!$showpost['pid'])
{
error($lang->error_invalidpost);

		}


		}


		$attachcache = array();
if($mybb->settings['enableattachments'] == 1 && $thread['attachmentcount'] > 0 || is_moderator($fid, 'caneditposts'))

		$attachcache = array();
if($mybb->settings['enableattachments'] == 1 && $thread['attachmentcount'] > 0 || is_moderator($fid, 'caneditposts'))

		{

		{

			// Get the attachments for this post.
$query = $db->simple_select("attachments", "*", "pid=".$mybb->input['pid']);
while($attachment = $db->fetch_array($query))

			// Get the attachments for this post.
$query = $db->simple_select("attachments", "*", "pid=".$mybb->input['pid']);
while($attachment = $db->fetch_array($query))

			{

			{

				$attachcache[$attachment['pid']][$attachment['aid']] = $attachment;
}

				$attachcache[$attachment['pid']][$attachment['aid']] = $attachment;
}

		}

// Build the threaded post display tree.
$query = $db->query("
SELECT p.username, p.uid, p.pid, p.replyto, p.subject, p.dateline
FROM ".TABLE_PREFIX."posts p
WHERE p.tid='$tid'
$visible
ORDER BY p.dateline
");
if(!is_array($postsdone))
{
$postsdone = array();
}
while($post = $db->fetch_array($query))
{
if(!$postsdone[$post['pid']])
{
if($post['pid'] == $mybb->input['pid'] || ($isfirst && !$mybb->input['pid']))
{
$postcounter = count($postsdone);
$isfirst = 0;
}
$tree[$post['replyto']][$post['pid']] = $post;
$postsdone[$post['pid']] = 1;
}
}

		}

$multipage = '';

// Build the threaded post display tree.
$query = $db->query("
SELECT p.username, p.uid, p.pid, p.replyto, p.subject, p.dateline
FROM ".TABLE_PREFIX."posts p
WHERE p.tid='$tid'
$visibleonly_p
ORDER BY p.dateline, p.pid
");
$postsdone = array();
while($post = $db->fetch_array($query))
{
if(empty($postsdone[$post['pid']]))
{
if($post['pid'] == $mybb->input['pid'] || ($isfirst && !$mybb->input['pid']))
{
$postcounter = count($postsdone);
$isfirst = 0;
}
$tree[$post['replyto']][$post['pid']] = $post;
$postsdone[$post['pid']] = 1;
}
}



$threadedbits = buildtree();
$posts = build_postbit($showpost);


$threadedbits = buildtree();
$posts = build_postbit($showpost);

Zeile 928Zeile 915
	}
else // Linear display
{

	}
else // Linear display
{

 
		$thread_toggle = 'threaded';

		$threadexbox = '';
if(!$mybb->settings['postsperpage'] || (int)$mybb->settings['postsperpage'] < 1)
{
$mybb->settings['postsperpage'] = 20;

		$threadexbox = '';
if(!$mybb->settings['postsperpage'] || (int)$mybb->settings['postsperpage'] < 1)
{
$mybb->settings['postsperpage'] = 20;

		}

		}


// Figure out if we need to display multiple pages.
$page = 1;


// Figure out if we need to display multiple pages.
$page = 1;

Zeile 945Zeile 933
		if(!empty($mybb->input['pid']))
{
$post = get_post($mybb->input['pid']);

		if(!empty($mybb->input['pid']))
{
$post = get_post($mybb->input['pid']);

			if(empty($post) || ($post['visible'] == 0 && !is_moderator($post['fid'], 'canviewunapprove')) || ($post['visible'] == -1 && !is_moderator($post['fid'], 'canviewdeleted') && $forumpermissions['canviewdeletionnotice'] == 0))










			if(
empty($post) ||
(
$post['visible'] == 0 && !(
is_moderator($post['fid'], 'canviewunapprove') ||
($mybb->user['uid'] && $post['uid'] == $mybb->user['uid'] && $mybb->settings['showownunapproved'])
)
) ||
($post['visible'] == -1 && !is_moderator($post['fid'], 'canviewdeleted') && $forumpermissions['canviewdeletionnotice'] == 0)
)

			{
$footer .= '<script type="text/javascript">$(function() { $.jGrowl(\''.$lang->error_invalidpost.'\', {theme: \'jgrowl_error\'}); });</script>';
}

			{
$footer .= '<script type="text/javascript">$(function() { $.jGrowl(\''.$lang->error_invalidpost.'\', {theme: \'jgrowl_error\'}); });</script>';
}

Zeile 955Zeile 952
					SELECT COUNT(p.dateline) AS count FROM ".TABLE_PREFIX."posts p
WHERE p.tid = '{$tid}'
AND p.dateline <= '{$post['dateline']}'

					SELECT COUNT(p.dateline) AS count FROM ".TABLE_PREFIX."posts p
WHERE p.tid = '{$tid}'
AND p.dateline <= '{$post['dateline']}'

					{$visible}

					{$visibleonly_p}

				");
$result = $db->fetch_field($query, "count");
if(($result % $perpage) == 0)

				");
$result = $db->fetch_field($query, "count");
if(($result % $perpage) == 0)

Zeile 970Zeile 967
		}

// Recount replies if user is a moderator or can see the deletion notice to take into account unapproved/deleted posts.

		}

// Recount replies if user is a moderator or can see the deletion notice to take into account unapproved/deleted posts.

		if($ismod || $forumpermissions['canviewdeletionnotice'] != 0)

		if($visible_states != array("1"))

		{

		{

			$query = $db->simple_select("posts p", "COUNT(*) AS replies", "p.tid='$tid' $visible");

 
			$cached_replies = $thread['replies']+$thread['unapprovedposts']+$thread['deletedposts'];

			$cached_replies = $thread['replies']+$thread['unapprovedposts']+$thread['deletedposts'];

			$thread['replies'] = $db->fetch_field($query, 'replies')-1;

// The counters are wrong? Rebuild them
// This doesn't cover all cases however it is a good addition to the manual rebuild function
if($thread['replies'] != $cached_replies)
{
require_once MYBB_ROOT."/inc/functions_rebuild.php";
rebuild_thread_counters($thread['tid']);







$query = $db->simple_select("posts p", "COUNT(*) AS replies", "p.tid='$tid' $visibleonly_p");
$thread['replies'] = $db->fetch_field($query, 'replies')-1;

if(in_array('-1', $visible_states) && in_array('0', $visible_states))
{
// The counters are wrong? Rebuild them
// This doesn't cover all cases however it is a good addition to the manual rebuild function
if($thread['replies'] != $cached_replies)
{
require_once MYBB_ROOT."/inc/functions_rebuild.php";
rebuild_thread_counters($thread['tid']);
}

			}

			}

		}
elseif($forumpermissions['canviewdeletionnotice'] != 0)
{
$thread['replies'] += $thread['deletedposts'];

 
		}

$postcount = (int)$thread['replies']+1;

		}

$postcount = (int)$thread['replies']+1;

Zeile 996Zeile 993
		if($mybb->get_input('page') == "last")
{
$page = $pages;

		if($mybb->get_input('page') == "last")
{
$page = $pages;

		}


		}


		if($page > $pages || $page <= 0)
{
$page = 1;

		if($page > $pages || $page <= 0)
{
$page = 1;

Zeile 1015Zeile 1012
		$upper = $start+$perpage;

// Work out if we have terms to highlight

		$upper = $start+$perpage;

// Work out if we have terms to highlight

        $highlight = "";
$threadmode = "";
if($mybb->seo_support == true)
{
if($mybb->get_input('highlight'))
{
$highlight = "?highlight=".urlencode($mybb->get_input('highlight'));
}

if($defaultmode != "linear")
{
if($mybb->get_input('highlight'))
{
$threadmode = "&amp;mode=linear";
}
else
{
$threadmode = "?mode=linear";
}

		$highlight = "";
$threadmode = "";
if($mybb->seo_support == true)
{
if($mybb->get_input('highlight'))
{
$highlight = "?highlight=".urlencode($mybb->get_input('highlight'));
}

if($defaultmode != "linear")
{
if($mybb->get_input('highlight'))
{
$threadmode = "&amp;mode=linear";
}
else
{
$threadmode = "?mode=linear";
}

			}

			}

        }
else
{

		}
else
{

			if(!empty($mybb->input['highlight']))
{
if(is_array($mybb->input['highlight']))

			if(!empty($mybb->input['highlight']))
{
if(is_array($mybb->input['highlight']))

Zeile 1053Zeile 1050
				}
}


				}
}


            if($defaultmode != "linear")
{
$threadmode = "&amp;mode=linear";
}
}

$multipage = multipage($postcount, $perpage, $page, str_replace("{tid}", $tid, THREAD_URL_PAGED.$highlight.$threadmode));

// Allow originator to see own unapproved posts
if($mybb->user['uid'] && $mybb->settings['showownunapproved'])
{
$visible .= " OR (p.tid='$tid' AND p.visible='0' AND p.uid=".$mybb->user['uid'].")";

			if($defaultmode != "linear")
{
$threadmode = "&amp;mode=linear";
}









		}

		}

 

$multipage = multipage($postcount, $perpage, $page, str_replace("{tid}", $tid, THREAD_URL_PAGED.$highlight.$threadmode));


// Lets get the pids of the posts on this page.
$pids = "";
$comma = '';


// Lets get the pids of the posts on this page.
$pids = "";
$comma = '';

		$query = $db->simple_select("posts p", "p.pid", "p.tid='$tid' $visible", array('order_by' => 'p.dateline', 'limit_start' => $start, 'limit' => $perpage));

		$query = $db->simple_select("posts p", "p.pid", "p.tid='$tid' $visibleonly_p", array('order_by' => 'p.dateline, p.pid', 'limit_start' => $start, 'limit' => $perpage));

		while($getid = $db->fetch_array($query))
{
// Set the ID of the first post on page to $pid if it doesn't hold any value

		while($getid = $db->fetch_array($query))
{
// Set the ID of the first post on page to $pid if it doesn't hold any value

Zeile 1115Zeile 1106
			LEFT JOIN ".TABLE_PREFIX."userfields f ON (f.ufid=u.uid)
LEFT JOIN ".TABLE_PREFIX."users eu ON (eu.uid=p.edituid)
WHERE $pids

			LEFT JOIN ".TABLE_PREFIX."userfields f ON (f.ufid=u.uid)
LEFT JOIN ".TABLE_PREFIX."users eu ON (eu.uid=p.edituid)
WHERE $pids

			ORDER BY p.dateline

			ORDER BY p.dateline, p.pid

		");
while($post = $db->fetch_array($query))
{

		");
while($post = $db->fetch_array($query))
{

Zeile 1128Zeile 1119
		}
$plugins->run_hooks("showthread_linear");
}

		}
$plugins->run_hooks("showthread_linear");
}

 
	$lang->thread_toggle = $lang->{$thread_toggle};


// Show the similar threads table if wanted.
$similarthreads = '';


// Show the similar threads table if wanted.
$similarthreads = '';

Zeile 1231Zeile 1223

// Decide whether or not to show quick reply.
$quickreply = '';


// Decide whether or not to show quick reply.
$quickreply = '';

	if($forumpermissions['canpostreplys'] != 0 && $mybb->user['suspendposting'] != 1 && ($thread['closed'] != 1 || is_moderator($fid, "canpostclosedthreads")) && $mybb->settings['quickreply'] != 0 && $mybb->user['showquickreply'] != '0' && $forum['open'] != 0 && ($thread['uid'] == $mybb->user['uid'] || $forumpermissions['canonlyreplyownthreads'] != 1))

	if($forumpermissions['canpostreplys'] != 0 && $mybb->user['suspendposting'] != 1 && ($thread['closed'] != 1 || is_moderator($fid, "canpostclosedthreads")) && $mybb->settings['quickreply'] != 0 && $mybb->user['showquickreply'] != '0' && $forum['open'] != 0 && ($thread['uid'] == $mybb->user['uid'] || empty($forumpermissions['canonlyreplyownthreads'])))

	{
$query = $db->simple_select("posts", "pid", "tid='{$tid}'", array("order_by" => "pid", "order_dir" => "desc", "limit" => 1));
$last_pid = $db->fetch_field($query, "pid");

	{
$query = $db->simple_select("posts", "pid", "tid='{$tid}'", array("order_by" => "pid", "order_dir" => "desc", "limit" => 1));
$last_pid = $db->fetch_field($query, "pid");

Zeile 1289Zeile 1281
			}
}


			}
}


	    	$posthash = md5($mybb->user['uid'].random_str());
$expaltext = (in_array("quickreply", $collapse)) ? "[+]" : "[-]";















			$posthash = md5($mybb->user['uid'].random_str());

if(!isset($collapsedthead['quickreply']))
{
$collapsedthead['quickreply'] = '';
}
if(!isset($collapsedimg['quickreply']))
{
$collapsedimg['quickreply'] = '';
}
if(!isset($collapsed['quickreply_e']))
{
$collapsed['quickreply_e'] = '';
}

$expaltext = (in_array("quickreply", $collapse)) ? $lang->expcol_expand : $lang->expcol_collapse;

		eval("\$quickreply = \"".$templates->get("showthread_quickreply")."\";");
}

$moderationoptions = '';

		eval("\$quickreply = \"".$templates->get("showthread_quickreply")."\";");
}

$moderationoptions = '';

 
	$threadnotesbox = $viewnotes = '';


// If the user is a moderator, show the moderation tools.
if($ismod)
{
$customthreadtools = $customposttools = $standardthreadtools = $standardposttools = '';



// If the user is a moderator, show the moderation tools.
if($ismod)
{
$customthreadtools = $customposttools = $standardthreadtools = $standardposttools = '';


		$threadnotesbox = $viewnotes = '';

 
		if(!empty($thread['notes']))
{
$thread['notes'] = nl2br(htmlspecialchars_uni($thread['notes']));

		if(!empty($thread['notes']))
{
$thread['notes'] = nl2br(htmlspecialchars_uni($thread['notes']));

Zeile 1312Zeile 1318
				$thread['notes'] = my_substr($thread['notes'], 0, 200)."... {$viewnotes}";
}


				$thread['notes'] = my_substr($thread['notes'], 0, 200)."... {$viewnotes}";
}


			$expaltext = (in_array("threadnotes", $collapse)) ? "[+]" : "[-]";

			$expaltext = (in_array("threadnotes", $collapse)) ? $lang->expcol_expand : $lang->expcol_collapse;

			eval("\$threadnotesbox = \"".$templates->get("showthread_threadnotes")."\";");
}


			eval("\$threadnotesbox = \"".$templates->get("showthread_threadnotes")."\";");
}


Zeile 1321Zeile 1327
			$gids = explode(',', $mybb->user['additionalgroups']);
$gids[] = $mybb->user['usergroup'];
$gids = array_filter(array_unique($gids));

			$gids = explode(',', $mybb->user['additionalgroups']);
$gids[] = $mybb->user['usergroup'];
$gids = array_filter(array_unique($gids));

 
			$gidswhere = '';

			switch($db->type)
{
case "pgsql":

			switch($db->type)
{
case "pgsql":

Zeile 1492Zeile 1499
	{
$query = $db->simple_select("threadsubscriptions", "tid", "tid='".(int)$tid."' AND uid='".(int)$mybb->user['uid']."'", array('limit' => 1));


	{
$query = $db->simple_select("threadsubscriptions", "tid", "tid='".(int)$tid."' AND uid='".(int)$mybb->user['uid']."'", array('limit' => 1));


		if($db->fetch_field($query, 'tid'))

		if($db->num_rows($query) > 0)

		{
$add_remove_subscription = 'remove';
$add_remove_subscription_text = $lang->unsubscribe_thread;
}

eval("\$addremovesubscription = \"".$templates->get("showthread_subscription")."\";");

		{
$add_remove_subscription = 'remove';
$add_remove_subscription_text = $lang->unsubscribe_thread;
}

eval("\$addremovesubscription = \"".$templates->get("showthread_subscription")."\";");

 
	}
else
{
$addremovesubscription = '';

	}

$classic_header = '';

	}

$classic_header = '';

Zeile 1540Zeile 1551
				$doneusers[$user['uid']] = $user['time'];

$invisiblemark = '';

				$doneusers[$user['uid']] = $user['time'];

$invisiblemark = '';

				if($user['invisible'] == 1)

				if($user['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)

				{
$invisiblemark = "*";
++$inviscount;

				{
$invisiblemark = "*";
++$inviscount;

Zeile 1572Zeile 1583
		}
if($inviscount && $mybb->usergroup['canviewwolinvis'] != 1)
{

		}
if($inviscount && $mybb->usergroup['canviewwolinvis'] != 1)
{

			$invisonline = $lang->sprintf($lang->users_browsing_forum_invis, $inviscount);

			$invisonline = $lang->sprintf($lang->users_browsing_thread_invis, $inviscount);

		}

$onlinesep = '';

		}

$onlinesep = '';

Zeile 1590Zeile 1601
		eval("\$usersbrowsing = \"".$templates->get("showthread_usersbrowsing")."\";");
}


		eval("\$usersbrowsing = \"".$templates->get("showthread_usersbrowsing")."\";");
}


	if($thread['visible'] == -1 )


	$thread_deleted = 0;
if($thread['visible'] == -1)

	{
$thread_deleted = 1;
}

	{
$thread_deleted = 1;
}

Zeile 1640Zeile 1652
				eval("\$posts .= \"".$templates->get("showthread_threaded_bit")."\";");
}


				eval("\$posts .= \"".$templates->get("showthread_threaded_bit")."\";");
}


			if($tree[$post['pid']])

			if(!empty($tree[$post['pid']]))

			{
$posts .= buildtree($post['pid'], $indent);
}

			{
$posts .= buildtree($post['pid'], $indent);
}